Fix mount disk error (#4204)

* wait for mounting to assign disk letter

* update

* Gabi fixing my slop with a comment

.github/ISSUE_TEMPLATE/bug_report.yaml

@@ -6,20 +6,8 @@ body:
   - type: markdown
     attributes:
       value: |
-        ## ⚠️ **IMPORTANT**
-        - 🛠️ **Supported environments only:** We only support Windows 11.
-        - 💡 For general questions, use the [Discussions section](https://github.com/Christitustech/winutil/discussions) or join our Community-driven [Discord Server](https://discord.gg/RUbZUZyByQ).
-
-  - type: checkboxes
-    attributes:
-      label: ⚙️ Issue Checklist
-      options:
-        - label: I have read the guidelines.
-        - label: I checked for duplicate issues.
-        - label: I searched for existing discussions.
-        - label: I checked for an existing pull request that addresses this issue.
-    validations:
-      required: true
+        - Remember, we only support Windows 11. If you encounter problems on Windows 10, please consider upgrading to Windows 11.
+        - For general questions, join our Community-driven [Discord Server](https://discord.gg/RUbZUZyByQ).
 
   - type: dropdown
     id: affected_part
@@ -32,17 +20,17 @@ body:
         - Updates Tab
         - Win11 Creator Tab
     validations:
-      required: true
+      required: false
 
   - type: textarea
     id: issue_description
     attributes:
-      label: 📝 Provide a clear and concise description of the issue.
+      label: Provide a clear and concise description of the issue.
     validations:
       required: true
 
   - type: textarea
     id: error_output
     attributes:
-      label: ❌ Paste the full error output (if available) or Screenshot.
+      label: Paste the full error output (if available) or Screenshot.
       placeholder: "Include any relevant logs or error messages."

config/tweaks.json

@@ -88,9 +88,9 @@
     "link": "https://winutil.christitus.com/dev/tweaks/essential-tweaks/widget"
   },
   "WPFTweaksRevertStartMenu": {
-    "Content": "Revert the new start menu",
-    "Description": "Uses vivetool to revert to the original start menu from 24H2.",
-    "category": "z__Advanced Tweaks - CAUTION",
+    "Content": "Revert Start Menu layout",
+    "Description": "Bring back the old Start Menu layout from before the gradual rollout of the new one in 25H2.",
+    "category": "Essential Tweaks",
     "panel": "1",
     "InvokeScript": [
       "
@@ -120,7 +120,7 @@
       Write-Host 'New start menu reverted please restart your computer to take effect'
       "
     ],
-    "link": "https://winutil.christitus.com/dev/tweaks/z--advanced-tweaks---caution/revertstartmenu"
+    "link": "https://winutil.christitus.com/dev/tweaks/essential-tweaks/revertstartmenu"
   },
   "WPFTweaksDisableStoreSearch": {
     "Content": "Disable Microsoft Store search results",

docs/content/dev/tweaks/Essential-Tweaks/RevertStartMenu.md

@@ -1,13 +1,13 @@
 ---
-title: "Revert the new start menu"
+title: "Revert Start Menu layout"
 description: ""
 ---
 
 ```json {filename="config/tweaks.json",linenos=inline,linenostart=90}
   "WPFTweaksRevertStartMenu": {
-    "Content": "Revert the new start menu",
-    "Description": "Uses vivetool to revert to the original start menu from 24H2.",
-    "category": "z__Advanced Tweaks - CAUTION",
+    "Content": "Revert Start Menu layout",
+    "Description": "Bring back the old Start Menu layout from before the gradual rollout of the new one in 25H2.",
+    "category": "Essential Tweaks",
     "panel": "1",
     "InvokeScript": [
       "

functions/private/Invoke-WinUtilISO.ps1

@@ -49,8 +49,13 @@ function Invoke-WinUtilISOMountAndVerify {
     Set-WinUtilProgressBar -Label "Mounting ISO..." -Percent 10
 
     try {
-        $diskImage   = Mount-DiskImage -ImagePath $isoPath -PassThru -ErrorAction Stop
-        $driveLetter = ($diskImage | Get-Volume).DriveLetter + ":"
+        Mount-DiskImage -ImagePath $isoPath -ErrorAction Stop | Out-Null
+
+        do {
+            Start-Sleep -Milliseconds 500
+        } until ((Get-DiskImage -ImagePath $isoPath | Get-Volume).DriveLetter)
+
+        $driveLetter = (Get-DiskImage -ImagePath $isoPath | Get-Volume).DriveLetter + ":"
         Write-Win11ISOLog "Mounted at drive $driveLetter"
 
         Set-WinUtilProgressBar -Label "Verifying ISO contents..." -Percent 30
@@ -144,6 +149,7 @@ function Invoke-WinUtilISOModify {
     Write-Win11ISOLog "Selected edition: $selectedEditionName (Index $selectedWimIndex)"
 
     $sync["WPFWin11ISOModifyButton"].IsEnabled = $false
+    $sync["Win11ISOModifying"] = $true
 
     $existingWorkDir = Get-Item -Path (Join-Path $env:TEMP "WinUtil_Win11ISO*") -ErrorAction SilentlyContinue |
         Where-Object { $_.PSIsContainer } | Sort-Object LastWriteTime -Descending | Select-Object -First 1
@@ -303,6 +309,7 @@ function Invoke-WinUtilISOModify {
             })
         } finally {
             Start-Sleep -Milliseconds 800
+            $sync["Win11ISOModifying"] = $false
             $sync["WPFWin11ISOStatusLog"].Dispatcher.Invoke([action]{
                 $sync.progressBarTextBlock.Text    = ""
                 $sync.progressBarTextBlock.ToolTip = ""
@@ -323,6 +330,11 @@ function Invoke-WinUtilISOModify {
 function Invoke-WinUtilISOCheckExistingWork {
     if ($sync["Win11ISOContentsDir"] -and (Test-Path $sync["Win11ISOContentsDir"])) { return }
 
+    # Check if ISO modification is currently in progress
+    if ($sync["Win11ISOModifying"]) {
+        return
+    }
+
     $existingWorkDir = Get-Item -Path (Join-Path $env:TEMP "WinUtil_Win11ISO*") -ErrorAction SilentlyContinue |
         Where-Object { $_.PSIsContainer } | Sort-Object LastWriteTime -Descending | Select-Object -First 1