Cleanup programs install (#4465)

* Cleanup programs install * Update Install-WinUtilProgramChoco.ps1
2026-06-04 22:27:28 +00:00 · 2026-05-12 11:06:13 -07:00
parent 3e16817640
commit d46d324df8
2 changed files with 20 additions and 381 deletions
@@ -1,135 +1,16 @@
 Function Install-WinUtilProgramWinget {
-    <#
-    .SYNOPSIS
-    Runs the designated action on the provided programs using Winget
-
-    .PARAMETER Programs
-    A list of programs to process
-
-    .PARAMETER action
-    The action to perform on the programs, can be either 'Install' or 'Uninstall'
-
-    .NOTES
-    The triple quotes are required any time you need a " in a normal script block.
-    The winget Return codes are documented here: https://github.com/microsoft/winget-cli/blob/master/doc/windows/package-actionr/winget/returnCodes.md
-    #>
-
-    param(
-        [Parameter(Mandatory, Position=0)]$Programs,
-
-        [Parameter(Mandatory, Position=1)]
+    param (
+        [Parameter(Mandatory=$true)]
        [ValidateSet("Install", "Uninstall")]
-        [String]$Action
+        [string]$Action,
+
+        [Parameter(Mandatory=$true)]
+        [string[]]$Programs
    )

-    Function Invoke-Winget {
-    <#
-    .SYNOPSIS
-    Invokes the winget.exe with the provided arguments and return the exit code
-
-    .PARAMETER wingetId
-    The Id of the Program that WinGet should Install/Uninstall
-
-    .NOTES
-    Invoke WinGet uses the public variable $Action defined outside the function to determine if a Program should be installed or removed
-    #>
-        param (
-            [string]$wingetId
-        )
-
-        $commonArguments = "--id $wingetId --silent"
-        $arguments = if ($Action -eq "Install") {
-            "install $commonArguments --accept-source-agreements --accept-package-agreements --source winget"
-        } else {
-            "uninstall $commonArguments --source winget"
-        }
-
-        $processParams = @{
-            FilePath = "winget"
-            ArgumentList = $arguments
-            Wait = $true
-            PassThru = $true
-            NoNewWindow = $true
-        }
-
-        return (Start-Process @processParams).ExitCode
+    if ($Action -eq 'Install') {
+        Start-Process -FilePath winget -ArgumentList "install $Programs --accept-package-agreements --source winget --silent" -NoNewWindow -Wait
+    } else {
+        Start-Process -FilePath winget -ArgumentList "uninstall $Programs --source winget --silent" -NoNewWindow -Wait
    }
-
-    Function Invoke-Install {
-    <#
-    .SYNOPSIS
-    Contains the Install Logic and return code handling from winget
-
-    .PARAMETER Program
-    The WinGet ID of the Program that should be installed
-    #>
-        param (
-            [string]$Program
-        )
-        $status = Invoke-Winget -wingetId $Program
-        if ($status -eq 0) {
-            Write-Host "$($Program) installed successfully."
-            return $true
-        } elseif ($status -eq -1978335189) {
-            Write-Host "No applicable update found for $($Program)."
-            return $true
-        }
-
-        Write-Host "Failed to install $($Program)."
-        return $false
-    }
-
-    Function Invoke-Uninstall {
-        <#
-        .SYNOPSIS
-        Contains the Uninstall Logic and return code handling from WinGet
-
-        .PARAMETER Program
-        The WinGet ID of the Program that should be uninstalled
-        #>
-        param (
-            [string]$Program
-        )
-
-        try {
-            $status = Invoke-Winget -wingetId $Program
-            if ($status -eq 0) {
-                Write-Host "$($Program) uninstalled successfully."
-                return $true
-            } else {
-                Write-Host "Failed to uninstall $($Program)."
-                return $false
-            }
-        } catch {
-            Write-Host "Failed to uninstall $($Program) due to an error: $_"
-            return $false
-        }
-    }
-
-    $count = $Programs.Count
-    $failedPackages = @()
-
-    Write-Host "==========================================="
-    Write-Host "--    Configuring WinGet packages       ---"
-    Write-Host "==========================================="
-
-    for ($i = 0; $i -lt $count; $i++) {
-        $Program = $Programs[$i]
-        $result = $false
-        Set-WinUtilProgressBar -label "$Action $($Program)" -percent ($i / $count * 100)
-        Invoke-WPFUIThread -ScriptBlock{ Set-WinUtilTaskbaritem -value ($i / $count)}
-
-        $result = switch ($Action) {
-            "Install" {Invoke-Install -Program $Program}
-            "Uninstall" {Invoke-Uninstall -Program $Program}
-            default {throw "[Install-WinUtilProgramWinget] Invalid action: $Action"}
-        }
-
-        if (-not $result) {
-            $failedPackages += $Program
-        }
-    }
-
-    Set-WinUtilProgressBar -label "$($Action) action done." -percent 100
-    return $failedPackages
 }